[video_player] Fix video player plugin freeze issue #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When flutter engine upgrade to 2.5.1, only call mark frame available API can triggle previous frame destruction callback.
|
I tested the example app on a watch 5.5 emulator and a watch 5.5 device, but flickering occurred frequently during video play and empty frames were displayed when the video was paused. Is this a known issue? The same thing occurs on a mobile 6.0 emulator so maybe it's not an Evas GL renderer-specific issue. |
swift-kim
reviewed
Nov 1, 2021
bbrto21
reviewed
Nov 1, 2021
There was a problem hiding this comment.
Several errors occur playing video, but the video is played well on TM1
E/ConsoleMessage(19508): [ERROR:flutter/lib/ui/ui_dart_state.cc(209)] Unhandled Exception: PlatformException(player_set_playback_rate failed, Function not implemented, null, null)
E/ConsoleMessage(19508): #0 VideoPlayerApi.setPlaybackSpeed (package:video_player_platform_interface/messages.dart:290:7)
E/ConsoleMessage(19508): <asynchronous suspension>
E/ConsoleMessage(19508): #1 VideoPlayerController._applyPlaybackSpeed (package:video_player/video_player.dart:495:5)
E/ConsoleMessage(19508): <asynchronous suspension>
E/ConsoleMessage(19508): #2 VideoPlayerController._applyPlayPause (package:video_player/video_player.dart:471:7)
E/ConsoleMessage(19508): <asynchronous suspension>
E/ConsoleMessage(19508): #3 VideoPlayerController.play (package:video_player/video_player.dart:422:5)
E/ConsoleMessage(19508): <asynchronous suspension>
E/ConsoleMessage(19508): [ERROR:flutter/lib/ui/ui_dart_state.cc(209)] Unhandled Exception: Null check operator used on a null value
E/ConsoleMessage(19508): #0 VideoPlayerController.initialize.errorListener (package:video_player/video_player.dart:381:51)
E/ConsoleMessage(19508): #1 _rootRunUnary (dart:async/zone.dart:1436:47)
E/ConsoleMessage(19508): #2 _CustomZone.runUnary (dart:async/zone.dart:1335:19)
E/ConsoleMessage(19508): #3 _CustomZone.runUnaryGuarded (dart:async/zone.dart:1244:7)
E/ConsoleMessage(19508): #4 _BufferingStreamSubscription._sendError.sendError (dart:async/stream_impl.dart:362:15)
E/ConsoleMessage(19508): #5 _BufferingStreamSubscription._sendError (dart:async/stream_impl.dart:378:7)
E/ConsoleMessage(19508): #6 _BufferingStreamSubscription._addError (dart:async/stream_impl.dart:280:7)
E/ConsoleMessage(19508): #7 _ForwardingStreamSubscription._addError (dart:async/stream_pipe.dart:128:11)
E/ConsoleMessage(19508): #8 _ForwardingStream._handleError (dart:async/stream_pipe.dart:95:10)
E/ConsoleMessage(19508): #9 _ForwardingStreamSubscription._handleError (dart:async/stream_pipe.dart:157:13)
E/ConsoleMessage(19508): #10 _rootRunBinary (dart:async/zone.dart:1452:47)
E/ConsoleMessage(19508): #11 _CustomZone.runBinary (dart:async/zone.dart:1342:19)
E/ConsoleMessage(19508): #12 _
E/ConsoleMessage(19508): CustomZone.runBinaryGuarded (dart:async/zone.dart:1252:7)
E/ConsoleMessage(19508): #13 _BufferingStreamSubscription._sendError.sendError (dart:async/stream_impl.dart:360:15)
E/ConsoleMessage(19508): #14 _BufferingStreamSubscription._sendError (dart:async/stream_impl.dart:378:7)
E/ConsoleMessage(19508): #15 _DelayedError.perform (dart:async/stream_impl.dart:602:14)
E/ConsoleMessage(19508): #16 _StreamImplEvents.handleNext (dart:async/stream_impl.dart:706:11)
E/ConsoleMessage(19508): #17 _PendingEvents.schedule.<anonymous closure> (dart:async/stream_impl.dart:663:7)
E/ConsoleMessage(19508): #18 _rootRun (dart:async/zone.dart:1420:47)
E/ConsoleMessage(19508): #19 _CustomZone.run (dart:async/zone.dart:1328:19)
E/ConsoleMessage(19508): #20 _CustomZone.runGuarded (dart:async/zone.dart:1236:7)
E/ConsoleMessage(19508): #21 _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1276:23)
E/ConsoleMessage(19508): #22 _rootRun (dart:async/zone.dart:1428:13)
E/ConsoleMessage(19508): #23 _CustomZone.run (dart:async/zone.dart:1328:19)
E/ConsoleMessage(19508): #24 _CustomZone.runGuarded (dart:async/zone.dart:1236:7)
E/ConsoleMessage(19508): #25 _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1276:23)
E/ConsoleMessage(19508): #26 _microtaskLoop (dart:async/schedule_mic
E/ConsoleMessage(19508): rotask.dart:40:21)
E/ConsoleMessage(19508): #27 _startMicrotaskLoop (dart:async/schedule_microtask.dart:49:5)
bwikbs
reviewed
Nov 1, 2021
I run the app on the TV device, and can reproduce flickering issue. |
bwikbs
approved these changes
Nov 2, 2021
3 tasks
#261 This is another issue, I will fix it. |
bbrto21
approved these changes
Nov 2, 2021
swift-kim
changed the title
bwikbs
pushed a commit
to bwikbs/plugins
that referenced
this pull request
Mar 26, 2022
* Fix video player plugin freeze issue When flutter engine upgrade to 2.5.1, only call mark frame available API can triggle previous frame destruction callback. * Rename IsValidMediaPacket to isValidMediaPacket * Rename using_media_packet_ to current_media_packet_ * Make isValidMediaPacket method name start with uppercase letter * When frame decode callback speed is faster than flutter renderer speed, skip old one and store new one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When flutter engine upgrade to 2.5.1, only call mark frame available
API can triggle previous frame destruction callback.
#250